Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand technical restrictions warning #201

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

mrsrec
Copy link
Contributor

@mrsrec mrsrec commented Aug 7, 2024

Pull request #194 added the use of a built-in message when a username starts with a lowercase letter. This functionality has been expanded. Now, there are custom messages, and they will show more often. There is a message for when a username uses impossible underscores, and a message for when a username begins with any letter, uppercase or lowercase. Instead of updating once, it updates as you type, so you can preview how it will look on-wiki. This is important to let people know that they can change the appearance of any letter, except the first one. This lets you see how it will look onwiki.

Closes #200

image

image

image

@mrsrec
Copy link
Contributor Author

mrsrec commented Aug 7, 2024

I added the text, but forgot the part where it...actually accepts different cases. Oops. I will add that soon.

@mrsrec
Copy link
Contributor Author

mrsrec commented Aug 8, 2024

Tested and now working.

Copy link
Member

@jacob-g jacob-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested on my local and works fine. In particular I made sure to test you can't get two active requests with the same username and different capitalization (e.g. "JVVG" and "jvvg"), and the existing database logic already takes care of that.

@jacob-g jacob-g merged commit ac0cb3f into InternationalScratchWiki:master Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow case-insensitive usernames in Scratch verification
2 participants