Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces client-side rate limiting and reduces maximum batch sizes to prevent overwhelming external APIs. The changes implement a token bucket rate limiter with configurable RPS and burst capacity, while decreasing batch size limits to reduce load on validity prover and store vault servers.
Key changes:
- Reduced
MAX_BATCH_SIZEfrom 128 to 32 for validity prover and from 256 to 64 for store vault server - Added
RequestRateLimiterwith cross-platform support (native and WASM) - Integrated rate limiting into
ValidityProverClient,StoreVaultServerClient, andS3StoreVaultClient
Reviewed Changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
interfaces/src/api/validity_prover/interface.rs |
Reduced MAX_BATCH_SIZE constant from 128 to 32 |
interfaces/src/api/store_vault_server/interface.rs |
Reduced MAX_BATCH_SIZE constant from 256 to 64 |
client-sdk/src/external_api/validity_prover.rs |
Added rate limiting to ValidityProverClient with helper methods for rate-limited requests |
client-sdk/src/external_api/utils/rate_limit.rs |
Implemented token bucket rate limiter with WASM and native support |
client-sdk/src/external_api/utils/mod.rs |
Exported rate_limit module |
client-sdk/src/external_api/store_vault_server.rs |
Integrated rate limiting into StoreVaultServerClient |
client-sdk/src/external_api/s3_store_vault.rs |
Integrated rate limiting into S3StoreVaultClient |
client-sdk/Cargo.toml |
Added instant dependency for WASM time support |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
smallbabybear
approved these changes
Oct 30, 2025
signature18632
added a commit
that referenced
this pull request
Oct 31, 2025
* feat: Integrated gnark (#448) * chore: update intmax2-zkp deps * feat: delete circuit dependency * feat: add some data * docs: update readme & testdata * chore: update proof * chore: fix limb error * Single history status (#453) * feat: entry status replace * feat: wip strategy replacement * feat: impl seperate group * feat: optional cursor * feat: impl fetch batch * feat: impl fetch batch wasm --------- Co-authored-by: kbizikav <132550763+kbizikav@users.noreply.github.com> * change os (#458) * feat: add get used memo func for wasm (#469) * feat: add get used memo func for wasm * fix: fix typo for ci * docs: added comprehensive docs for all nodes (#446) * chore: update docs * docs: add block builder docs * docs: add balance prover readme * docs: client sdk * docs: fix client sdk docs * docs: add validity prover docs * docs: add block builder data structure * docs: update block builder * docs: add withdrawal server docs * docs: add validity prover worker tasks * docs: delete legacy store vault server * docs: add pruning docs * docs: update validity prover docs * docs: update * docs: interface * docs: add Troubleshooting * fix: add membership verification during `add_signature` (#465) * fix: add membership verification during add_signature to prevent future panic * Update block-builder/src/app/storage/memory_storage.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update block-builder/src/app/storage/memory_storage.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix: typo for ci --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat: add rate limit & reduce max batch size (#464) * feat: add rate limit & reduce max batch size * feat: use wasm time * feat: longer rate limit * feat: remove AGENTS.md * fix: typo * Retry 502 error (#470) --------- Co-authored-by: Baby Bear <132609968+smallbabybear@users.noreply.github.com> --------- Co-authored-by: kbizikav <132550763+kbizikav@users.noreply.github.com> Co-authored-by: signature18632 <intmax18@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
signature18632
added a commit
that referenced
this pull request
Nov 13, 2025
* feat: Integrated gnark (#448) * chore: update intmax2-zkp deps * feat: delete circuit dependency * feat: add some data * docs: update readme & testdata * chore: update proof * chore: fix limb error * Single history status (#453) * feat: entry status replace * feat: wip strategy replacement * feat: impl seperate group * feat: optional cursor * feat: impl fetch batch * feat: impl fetch batch wasm --------- Co-authored-by: kbizikav <132550763+kbizikav@users.noreply.github.com> * change os (#458) * feat: add get used memo func for wasm (#469) * feat: add get used memo func for wasm * fix: fix typo for ci * docs: added comprehensive docs for all nodes (#446) * chore: update docs * docs: add block builder docs * docs: add balance prover readme * docs: client sdk * docs: fix client sdk docs * docs: add validity prover docs * docs: add block builder data structure * docs: update block builder * docs: add withdrawal server docs * docs: add validity prover worker tasks * docs: delete legacy store vault server * docs: add pruning docs * docs: update validity prover docs * docs: update * docs: interface * docs: add Troubleshooting * fix: add membership verification during `add_signature` (#465) * fix: add membership verification during add_signature to prevent future panic * Update block-builder/src/app/storage/memory_storage.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update block-builder/src/app/storage/memory_storage.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix: typo for ci --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat: add rate limit & reduce max batch size (#464) * feat: add rate limit & reduce max batch size * feat: use wasm time * feat: longer rate limit * feat: remove AGENTS.md * fix: typo * Retry 502 error (#470) --------- Co-authored-by: Baby Bear <132609968+smallbabybear@users.noreply.github.com> * fix(client): consume only invalid (#473) --------- Co-authored-by: kbizikav <132550763+kbizikav@users.noreply.github.com> Co-authored-by: signature18632 <intmax18@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.