Skip to content

fix: add membership verification during add_signature #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kbizikav merged 6 commits into from
Oct 29, 2025
Merged

fix: add membership verification during add_signature #465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4f405fb
fix: add membership verification during add_signature to prevent futu…
kbizikav Oct 24, 2025
87c558b
Update block-builder/src/app/storage/memory_storage.rs
kbizikav Oct 24, 2025
eed7853
Update block-builder/src/app/storage/memory_storage.rs
kbizikav Oct 24, 2025
78f2119
fix: typo for ci
kbizikav Oct 24, 2025
ac24aab
Merge branch 'dev' into fix-membership-verification
kbizikav Oct 29, 2025
09fefe8
Merge branch 'dev' into fix-membership-verification
kbizikav Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion block-builder/src/app/storage/memory_storage.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,14 @@ impl Storage for InMemoryStorage {
"memo not found for block_id: {block_id}"
)))?;

// verify signature
// Verify pubkey membership
if !memo.pubkeys.contains(&signature.pubkey) {
return Err(StorageError::AddSignatureError(format!(
"pubkey not found in memo for block_id: {block_id}"
)));
}

// Verify signature
signature
.verify(&memo.block_sign_payload, memo.pubkey_hash)
.map_err(|e| {
Expand Down
7 changes: 7 additions & 0 deletions block-builder/src/app/storage/redis_storage.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,13 @@ impl Storage for RedisStorage {

let memo: ProposalMemo = serde_json::from_str(&serialized_memo)?;

// Verify pubkey membership
if !memo.pubkeys.contains(&signature.pubkey) {
return Err(StorageError::AddSignatureError(format!(
"pubkey not found in memo for block_id: {block_id}"
)));
}

// Verify signature
signature
.verify(&memo.block_sign_payload, memo.pubkey_hash)
Expand Down