Skip to content

Retry 502 error #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smallbabybear merged 1 commit into from
Oct 30, 2025
Merged

Retry 502 error #470

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 39 additions & 4 deletions client-sdk/src/external_api/utils/query.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use intmax2_interfaces::api::error::ServerError;
use reqwest::{header, Client, Response, Url};
use serde::{de::DeserializeOwned, Deserialize, Serialize};

use crate::external_api::utils::retry::with_retry;
use crate::external_api::utils::{retry::with_retry, time::sleep_for};

/// Timeout for reqwest requests.
/// Because WASM only accepts timeout in the request builder, not the client builder,
Expand All @@ -13,6 +13,8 @@ pub const REQWEST_TIMEOUT: Duration = Duration::from_secs(30);

/// Maximum response body size for logging (in characters)
const MAX_RESPONSE_LOG_SIZE: usize = 500;
const DEFAULT_BAD_GATEWAY_RETRIES: u32 = 1;
const DEFAULT_BAD_GATEWAY_RETRY_DELAY_SECS: u64 = 30;

#[derive(Debug, Deserialize)]
struct ErrorResponse {
Expand Down Expand Up @@ -133,9 +135,42 @@ fn serialize_body_for_logging<B: Serialize>(body: Option<&B>) -> Result<BodyInfo
async fn execute_request_with_retry(
request_builder: reqwest::RequestBuilder,
) -> Result<Response, ServerError> {
with_retry(|| async { request_builder.try_clone().unwrap().send().await })
.await
.map_err(|e| ServerError::NetworkError(e.to_string()))
let max_502_retries: u32 = std::env::var("BAD_GATEWAY_RETRY_LIMIT")
.ok()
.and_then(|v| v.parse::<u32>().ok())
.unwrap_or(DEFAULT_BAD_GATEWAY_RETRIES);

let retry_delay_secs: u64 = std::env::var("BAD_GATEWAY_RETRY_DELAY_SECS")
.ok()
.and_then(|v| v.parse::<u64>().ok())
.unwrap_or(DEFAULT_BAD_GATEWAY_RETRY_DELAY_SECS);

let mut bad_gateway_retries: u32 = 0;

loop {
let response = with_retry(|| async { request_builder.try_clone().unwrap().send().await })
.await
.map_err(|e| ServerError::NetworkError(e.to_string()))?;

let status = response.status().as_u16();

if status != 502 {
return Ok(response);
}

if bad_gateway_retries >= max_502_retries {
return Ok(response);
}

log::warn!(
"Received 502 Bad Gateway from upstream. Waiting {delay}s before retry (attempt {}/{})",
bad_gateway_retries + 1,
max_502_retries,
delay = retry_delay_secs
);
sleep_for(retry_delay_secs).await;
bad_gateway_retries += 1;
}
}

/// Handles HTTP response, including error cases and deserialization
Expand Down