Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename AtMostBabbageEra to ShelleyToBabbageEra #127

Merged

Conversation

newhoggy
Copy link
Collaborator

@newhoggy newhoggy commented Jul 20, 2023

Changelog

- description: |
    Rename `AtMostBabbageEra` to `ShelleyToBabbageEra` and add `FeatureInEra` instances to `ShelleyToBabbageEra` and `ConwayEraOnwards`.
  compatibility: breaking
  type: feature

Context

The name ShelleyToBabbageEra more explicitly notes the absence of Byron and sets up the naming convention that allows for a starting era other than Shelley.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@newhoggy newhoggy marked this pull request as ready for review July 20, 2023 11:32

deriving instance Show (AtMostBabbageEra era)
deriving instance Eq (AtMostBabbageEra era)
instance FeatureInEra ConwayEraOnwards where
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these in use?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@newhoggy newhoggy added this pull request to the merge queue Jul 21, 2023
Merged via the queue into main with commit ab8c3ea Jul 21, 2023
@newhoggy newhoggy deleted the newhoggy/rename-AtMostBabbageEra-to-ShelleyToBabbageEra branch July 21, 2023 10:24
newhoggy added a commit that referenced this pull request Mar 11, 2024
…tasty-discover

Convert to use `tasty-discover`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants