-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tighten era bounds of Conway specific API to ConwayEraOnwards
#132
Conversation
95d87c2
to
6e2610e
Compare
VotingProcedure
and ProposalProcedure
to ConwayEraOnwards
VotingProcedure
and ProposalProcedure
to ConwayEraOnwards
ConwayEraOnwards
f47298b
to
d0d45fc
Compare
0b32f86
to
cf4e5e7
Compare
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
f140db1
to
d91f6af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to wait till after we have made sufficient progress in the cli.
bf13f20
to
3749ee4
Compare
28f54eb
to
cd151fc
Compare
6f01365
to
eed9c9a
Compare
eed9c9a
to
aac702e
Compare
This PR is stale because it has been open 45 days with no activity. |
Changelog
Context
Those functions and data types were constrained to
ShelleyBasedEra
previously, but that's too lose for something that's applicable to only Conway onwards.Those functions are now constrained to
ConwayEraOnwards
instead.Constraining to
ConwayEraOnwards
tightly allows the CLI parser to integrate with it in a type-safe way. This type-safety is what controls the visibility of CLI commands and options based on whether the era is Conway onwards.Checklist
.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7
Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.