Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HLint #133

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Fix HLint #133

merged 1 commit into from
Jul 25, 2023

Conversation

newhoggy
Copy link
Collaborator

Changelog

- description: |
    Fix HLint in CI
  compatibility: no-api-changes
  type: maintenance

Context

The HLint Github Action we are using appears to be unmaintained.:

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The warning can be seen here:

https://github.com/input-output-hk/cardano-api/actions/runs/5645037620

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@newhoggy newhoggy marked this pull request as ready for review July 24, 2023 13:04
@newhoggy newhoggy requested review from Jimbo4350, carbolymer and a team as code owners July 24, 2023 13:04
@newhoggy newhoggy added this pull request to the merge queue Jul 25, 2023
Merged via the queue into main with commit 396e6bd Jul 25, 2023
19 checks passed
@newhoggy newhoggy deleted the newhoggy/fix-hlint branch July 25, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants