-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix haddocks generation in GHA #241
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbolymer
force-pushed
the
mgalazyn/chore/fix-haddocks-gha
branch
4 times, most recently
from
September 13, 2023 14:29
fdf1b4d
to
8208c92
Compare
smelc
reviewed
Sep 13, 2023
carbolymer
force-pushed
the
mgalazyn/chore/fix-haddocks-gha
branch
2 times, most recently
from
September 14, 2023 07:39
ddc9b52
to
6d16b89
Compare
carbolymer
requested review from
Jimbo4350,
newhoggy,
a team,
disassembler and
CarlosLopezDeLara
as code owners
September 14, 2023 07:40
Closed
smelc
reviewed
Sep 14, 2023
When running the script locally, it fails with:
I suspect it's not an issue of this PR, but is there a way I could test the end of the script? (since it's the early |
@smelc you can try to follow the steps in |
newhoggy
approved these changes
Sep 14, 2023
Could be worthwhile converting this into a re-usable Github Action |
carbolymer
force-pushed
the
mgalazyn/chore/fix-haddocks-gha
branch
from
September 14, 2023 10:04
6d16b89
to
3096bbe
Compare
newhoggy
added a commit
that referenced
this pull request
Mar 11, 2024
…-address-command-group Era-based `stake-address` command group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
This PR reuses https://github.com/input-output-hk/cardano-node/blob/master/scripts/haddocs.sh from cardano-node
Fixes #188
Checklist
See Running tests for more details
.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7