Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typesafe ProtocolParameters fields #39

Conversation

newhoggy
Copy link
Collaborator

@newhoggy newhoggy commented Jun 5, 2023

Description

Add your description here, if it fixes a particular issue please provide a
link
to the issue.

Changelog

- description: |
    <insert-changelog-description-here>
  # no-changes: the API has not changed
  # compatible: the API has changed but is non-breaking
  # breaking: the API has changed in a breaking way
  compatibility: <no-api-changes|compatible|breaking>
  # feature: the change implements a new feature in the API
  # bugfix: the change fixes a bug in the API
  # test: the change fixes modifies tests
  # maintenance: the change involves something other than the API
  # If more than one is applicable, it may be put into a list.
  type: <feature|bugfix|test|maintenance>

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@newhoggy newhoggy changed the title Newhoggy/generate protocol update u tx o cost per byte in gen protocol parameters update era dependently 5 Typesafe ProtocolParameters fields Jun 5, 2023
@newhoggy newhoggy force-pushed the newhoggy/generate-protocolUpdateUTxOCostPerByte-in-genProtocolParametersUpdate-era-dependently-5 branch 3 times, most recently from d2c77e9 to 80c76c3 Compare June 8, 2023 13:56
@newhoggy newhoggy force-pushed the main branch 2 times, most recently from 4e5cfdd to 1abeff1 Compare June 14, 2023 11:20
@newhoggy newhoggy force-pushed the newhoggy/generate-protocolUpdateUTxOCostPerByte-in-genProtocolParametersUpdate-era-dependently-5 branch from 80c76c3 to f9ad6bb Compare June 22, 2023 12:11
@newhoggy newhoggy closed this Aug 11, 2023
newhoggy added a commit that referenced this pull request Mar 11, 2024
…no-api-8.5.2.0

Use new function-based API instead of using query data types directly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants