Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HLS version and add GitHub action #584

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Update HLS version and add GitHub action #584

merged 2 commits into from
Jul 15, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Jul 12, 2024

Changelog

- description: |
    Update GHC in Nix shell and HLS, and add GitHub action to verify HLS
# uncomment types applicable to the change:
  type:
  - test           # fixes/modifies tests
  - maintenance    # not directly related to the code

Context

This PR updates HLS to the latest version and ensures that it works on the repo by adding a GitHub action that checks.

How to trust this PR

Probably best to just test that it works for you.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas added enhancement New feature or request test Adding or reworking tests labels Jul 12, 2024
@palas palas self-assigned this Jul 12, 2024
flake.nix Outdated Show resolved Hide resolved
@smelc
Copy link
Contributor

smelc commented Jul 15, 2024

I confirm that HLS works for me on this PR 👍

Well done @palas 👏

Co-authored-by: Mateusz Galazyn <228866+carbolymer@users.noreply.github.com>
@palas palas added this pull request to the merge queue Jul 15, 2024
Merged via the queue into main with commit 15a5b13 Jul 15, 2024
25 checks passed
@palas palas deleted the fix-hls branch July 15, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test Adding or reworking tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants