Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to prettify #589

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Improvements to prettify #589

merged 2 commits into from
Jul 18, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Jul 17, 2024

Changelog

- description: |
     Added support for relative files and rebasing to the prettify tool, and add new checks on arguments
# uncomment types applicable to the change:
  type:
  - maintenance    # not directly related to the code

Context

When rebasing there was no option of prettify that would work (because changes while rebasing are neither staged nor unstaged, they are in the previous commit). So this PR adds an option -p that diffs against HEAD~1.

Also the tool would not work unless run from the top level in the repo, which is kind of inconvenient. So this change make prettify work from any subfolder.

This PR also imports changes from cardano-cli that improve checks on arguments (to give better error messages), and simplifies tool availability checking.

Twin PR #842 in cardano-cli

How to trust this PR

Probably testing is the best way to ensure it works. But they are few changes, so a quick look at the diff would also be nice.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas added this pull request to the merge queue Jul 18, 2024
Merged via the queue into main with commit 0fd29b0 Jul 18, 2024
24 of 26 checks passed
@palas palas deleted the improvements-to-prettify branch July 18, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants