Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect fees estimation when balancing transaction minting assets #622

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Fix incorrect fees estimation when balancing transaction minting assets #622

merged 2 commits into from
Aug 29, 2024

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Aug 23, 2024 •
edited
Loading

Changelog

- description: |
    Deprecate `valueFromList` and valueToList. Add `IsList Value` instance.
    Fix fee estimation when autobalancing assets minted in the transaction.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
   - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
   - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This PR should be reviewed on commit-by-commit basis.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer changed the title Add test case Fix incorrect fees estimation when balancing assets Aug 23, 2024
@carbolymer carbolymer changed the title Fix incorrect fees estimation when balancing assets Fix incorrect fees estimation when balancing transaction minting assets Aug 23, 2024
@carbolymer carbolymer marked this pull request as ready for review August 23, 2024 18:22
@carbolymer carbolymer marked this pull request as draft August 23, 2024 18:22
@carbolymer carbolymer force-pushed the mgalazyn/fix/invalid-fee-when-autobalancing-minting branch 3 times, most recently from 10c5809 to fdc91b3 Compare August 26, 2024 15:09
@carbolymer carbolymer force-pushed the mgalazyn/fix/invalid-fee-when-autobalancing-minting branch 7 times, most recently from a83f93b to 88aceab Compare August 29, 2024 07:28
@carbolymer carbolymer force-pushed the mgalazyn/fix/invalid-fee-when-autobalancing-minting branch from 88aceab to dc5d4cb Compare August 29, 2024 14:55
@carbolymer carbolymer marked this pull request as ready for review August 29, 2024 14:59
carbolymer
carbolymer commented Aug 29, 2024
View reviewed changes
cardano-api/internal/Cardano/Api/Fees.hs
UnsignedTx unsignedTx0 <-
first TxBodyError
$ makeUnsignedTx
availableEra
$ obtainShimConstraints bEraOnwards
$ txbodycontent
{ txOuts =
txOuts txbodycontent
++ [TxOut changeaddr (lovelaceToTxOutValue sbe 0) TxOutDatumNone ReferenceScriptNone]
-- TODO: think about the size of the change output
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jimbo4350 What does this TODO mean? This PR changes the TxOut to include all assets from TxIns and minted ones, so I guess this TODO is fixed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duncan left that there and I can't remember why.

carbolymer
carbolymer commented Aug 29, 2024
View reviewed changes
cardano-api/test/cardano-api-test/Test/Cardano/Api/Typed/TxBody.hs
address
Nothing
-- the correct amount with manual balancing of assets
335_729 === feeWithTxoutAsset
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR does not change the value of the fee here.

Jimbo4350
Jimbo4350 approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but one comment regarding the change output

cardano-api/internal/Cardano/Api/Fees.hs
UnsignedTx unsignedTx0 <-
first TxBodyError
$ makeUnsignedTx
availableEra
$ obtainShimConstraints bEraOnwards
$ txbodycontent
{ txOuts =
txOuts txbodycontent
++ [TxOut changeaddr (lovelaceToTxOutValue sbe 0) TxOutDatumNone ReferenceScriptNone]
-- TODO: think about the size of the change output
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duncan left that there and I can't remember why.

cardano-api/internal/Cardano/Api/Fees.hs Outdated
++ [TxOut changeaddr (lovelaceToTxOutValue sbe 0) TxOutDatumNone ReferenceScriptNone]
-- TODO: think about the size of the change output
-- 1,2,4 or 8 bytes?
TxOut changeaddr (TxOutValueShelleyBased sbe change) TxOutDatumNone ReferenceScriptNone
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we had an issue in the past where users were expecting the change output to be appended to the list of tx outs. We best not change it. There may be an issue about this floating around somewhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's just an intermediary txbodycontent for execution units calculation. I'll change the order.

@carbolymer carbolymer force-pushed the mgalazyn/fix/invalid-fee-when-autobalancing-minting branch from dc5d4cb to 7535526 Compare August 29, 2024 17:12
@carbolymer carbolymer added this pull request to the merge queue Aug 29, 2024
Merged via the queue into main with commit 00bb673 Aug 29, 2024
25 checks passed
@carbolymer carbolymer deleted the mgalazyn/fix/invalid-fee-when-autobalancing-minting branch August 29, 2024 17:39
@carbolymer carbolymer mentioned this pull request Sep 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts dcoutts is a code owner

@erikd erikd Awaiting requested review from erikd erikd is a code owner

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@smelc smelc Awaiting requested review from smelc smelc is a code owner

@palas palas Awaiting requested review from palas palas is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara CarlosLopezDeLara is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carbolymer @Jimbo4350