Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IsXXXBasedEra a class hierarchy #641

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

Swordlash
Copy link
Contributor

Changelog

- description: |
   Make `IsXXXBasedEra` a class hierarchy
  type:
  - compatible

Context

The PR makes IsXXXBasedEra a class hierarchy of one era being based of the next. I was surprised it's not the case in the code; I need to create a lot of dummy proofs like

maryFromAlonzo :: IsAlonzoBasedEra era => (IsMaryBasedEra era => a) -> a

in my projects.

How to trust this PR

It's a QOL improvement, just explicitly states a true fact of eras forming a chain.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

auto-merge was automatically disabled September 23, 2024 08:36

Head branch was pushed to by a user without write access

@Swordlash
Copy link
Contributor Author

@carbolymer can you reapprove? I had an unverified commit, should be good now.

@carbolymer carbolymer added this pull request to the merge queue Sep 23, 2024
Merged via the queue into IntersectMBO:main with commit a08aa37 Sep 23, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants