Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from cryptonite library to crypton #660

Closed
wants to merge 1 commit into from
Closed

Conversation

erikd
Copy link
Contributor

@erikd erikd commented Oct 22, 2024

The former library is deprecated in favor of the latter which is a drop in replacement.

Some of cardano-api's dependencies might still depend on the former but they will all be fixed eventually.

Changelog

- description: |
    Switch from cryptonite library to crypton
  type:
    - compatible     # the API has not changed

Context

How to trust this PR

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

The former library is deprecated in favor of the latter which is a drop
in replacement.

Some of cardano-api's dependencies might still depend on the former but
they will all be fixed eventually.
@carbolymer carbolymer added this pull request to the merge queue Oct 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 22, 2024
@carbolymer carbolymer added this pull request to the merge queue Oct 22, 2024
@erikd erikd removed this pull request from the merge queue due to a manual request Oct 22, 2024
@erikd erikd marked this pull request as draft October 22, 2024 08:26
@erikd
Copy link
Contributor Author

erikd commented Oct 22, 2024

Just discovered something wrong with this. Will look tomorrow.

@erikd
Copy link
Contributor Author

erikd commented Oct 23, 2024

This can't be done/fixed until the lower level libs (cardano-crypto, plutus, ledger etc) have been updated.

Closing this.

@erikd erikd closed this Oct 23, 2024
@erikd erikd deleted the erikd/crypton branch October 23, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants