Refactor TxMintValue
#663
Draft
Refactor TxMintValue
#663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbolymer
force-pushed
the
mgalazyn/feature/refactor-txmintvalue
branch
2 times, most recently
from
8b36408
to
ef2b00c
Compare
carbolymer
force-pushed
the
mgalazyn/feature/refactor-txmintvalue
branch
from
ef2b00c
to
c2c740b
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
carbolymer
force-pushed
the
mgalazyn/feature/refactor-txmintvalue
branch
7 times, most recently
from
555e92d
to
6e860f9
Compare
carbolymer
force-pushed
the
mgalazyn/feature/refactor-txmintvalue
branch
from
6e860f9
to
fefbe40
Compare
Jimbo4350
reviewed
Nov 6, 2024
| , (assetName', quantity, _) <- assets | ||
| ] | ||
|
|
||
| -- | Index the assets with witnesses in the order of policy ids. |
There was a problem hiding this comment.
Can you add a comment here referencing the spec and why we have to index on the order of policy ids?
| @@ -1588,7 +1619,7 @@ data TxBodyError | |||
| | TxBodyOutputNegative !Quantity !TxOutInAnyEra | |||
| | TxBodyOutputOverflow !Quantity !TxOutInAnyEra | |||
| | TxBodyMetadataError ![(Word64, TxMetadataRangeError)] | |||
| | TxBodyMintAdaError | |||
| | TxBodyMintAdaError -- TODO remove - case nonexistent | |||
|
|
||
| traverseScriptWitnesses | ||
| :: [(a, Either (TxBodyErrorAutoBalance era) (ScriptWitness ctx era))] | ||
| -> Either (TxBodyErrorAutoBalance era) [(a, ScriptWitness ctx era)] | ||
| :: [(a, Either (TxBodyErrorAutoBalance era) b)] |
There was a problem hiding this comment.
This may be "neater" Haskell but making this more generic doesn't really help the reader IMO. Also it's only instantiated to ScriptWitness ctx era.
There was a problem hiding this comment.
It's not only instantiated to ScriptWitness ctx era - in line 1629 is used against
[ (Value, Either (TxBodyErrorAutoBalance era)
( AssetName
, Quantity
, BuildTxWith build (ScriptWitness WitCtxMint era)
)
]| (Map PolicyId (ScriptWitness WitCtxMint era)) | ||
| -> Map | ||
| PolicyId | ||
| [ ( AssetName |
There was a problem hiding this comment.
A 3-tuple is less than ideal but I can't think of what to call this instead.
| @@ -676,6 +677,17 @@ data WitCtx witctx where | |||
| WitCtxMint :: WitCtx WitCtxMint | |||
| WitCtxStake :: WitCtx WitCtxStake | |||
|
|
|||
| -- TODO: not needed anymore - remove | |||
…WitnessReferenceInputOrScript functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist