-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flake improvements #76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Although the CHaP workaround could be better in explaining why this is necessary right now.
This helps haskell.nix find the package source correctly.
990c9ba
to
2c29490
Compare
6a13845
to
2c29490
Compare
Merging, but @disassembler can you please add an explanation as suggested by @angerman to the PR? |
From #69: This helps haskell.nix find the package source correctly. In particular new packages that are not in the main CHaP branch yet will be loaded correctly. To try it out you will need a local CHaP, this can be build with:
That will make a
Make sure to use |
Also we can update this once input-output-hk/haskell.nix#1984 is merged. |
--update-input
with CHaP works as expectedChangelog
Checklist
CHANGELOG.md
for affected package.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7
Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.