Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace --stake-verification-key-file with --deposit-return-stake-verification-key-file on all action commands #422

Closed
CarlosLopezDeLara opened this issue Nov 1, 2023 · 2 comments · Fixed by #470

Comments

@CarlosLopezDeLara
Copy link
Contributor

CarlosLopezDeLara commented Nov 1, 2023

We disambiguated treasury withdrawals which require 2 stake credentials with --deposit-return-stake-verification-key-file and --funds-receiving-stake-verification-key-file.

Well, users will appreciate if we have the same clarity on all other action commands, so we want to replace the existing --stake-verification-key-file flag with the more descriptive --deposit-return-stake-verification-key-file on all other governance actions

The same for --stake-verification-key and --stake-verification-key-hash

Replaced with

--deposit-return-stake-verification-key and

--deposit-return-stake-verification-key-hash, respectively.

@smelc
Copy link
Contributor

smelc commented Nov 10, 2023

Marking blocked, because solving this issue will affect the same places as:

So those two should be tackled first, to avoid merge conflicts hell. This will happen soon, so no worries about getting to this one soon.

@smelc
Copy link
Contributor

smelc commented Nov 22, 2023

Looking at --stake-verification-key-file, I believe the occurrences to change are as follows (red arrows):

image

I'm omitting:

  1. the pStakeAddressCmds caller in Cardano.CLI.Legacy.Options, because it's legacy.
  2. the pGovernanceActionTreasuryWithdrawalCmd caller. This one has been changed already, as stated in the issue's description.
  3. the pStakeVerifier caller in Cardano.CLI.Erabased.Options.Cmd, because it goes into non-governance commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants