Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accomodate ouroboros-api changes due to the BF PR #43

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Accomodate ouroboros-api changes due to the BF PR #43

merged 1 commit into from
Jul 10, 2023

Conversation

bolt12
Copy link
Contributor

@bolt12 bolt12 commented Jun 23, 2023 •
edited by carbolymer
Loading

Changelog

- description: |
    Accomodate ouroboros-consensus API changes
    Accomodate ouroboros-api API changes
  compatibility: no-api-changes
  type: feature

Context

This PR is related to IntersectMBO/ouroboros-consensus#140 & IntersectMBO/cardano-api#45 and is needed in order for IntersectMBO/cardano-node#4024 to compile.

SRP needs to be removed once we get a release from ouroboros-consensus, io-sim and cardano-api

@coot coot linked an issue Jun 27, 2023 that may be closed by this pull request
Enable block production dynamically IntersectMBO/ouroboros-network#3159
Closed
newhoggy
newhoggy reviewed Jun 28, 2023
View reviewed changes
cabal.project Outdated Show resolved Hide resolved
newhoggy
newhoggy reviewed Jun 28, 2023
View reviewed changes
cabal.project Outdated Show resolved Hide resolved
@bolt12 bolt12 force-pushed the bolt12/dynamic-block-forging branch from 3fbf9e1 to b30b9d1 Compare June 30, 2023 16:36
@bolt12 bolt12 force-pushed the bolt12/dynamic-block-forging branch from b30b9d1 to 66b675b Compare July 10, 2023 11:17
@bolt12 bolt12 requested a review from newhoggy July 10, 2023 11:22
carbolymer
carbolymer reviewed Jul 10, 2023
View reviewed changes
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but needs rebase

@bolt12 bolt12 force-pushed the bolt12/dynamic-block-forging branch from 66b675b to c2e18c7 Compare July 10, 2023 13:33
@bolt12 bolt12 added this pull request to the merge queue Jul 10, 2023
Merged via the queue into main with commit a2dfac7 Jul 10, 2023
@bolt12 bolt12 deleted the bolt12/dynamic-block-forging branch July 10, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbolymer carbolymer carbolymer approved these changes

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@newhoggy newhoggy Awaiting requested review from newhoggy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable block production dynamically
3 participants
@bolt12 @newhoggy @carbolymer