-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix haddocks generation - now using nix #445
Conversation
2f83a2f
to
f35cbfd
Compare
FIXME:
|
@andreabedini> would you have a clue why this PR only produces haddocks for tests (see @carbolymer's comment above: #445 (comment))? |
134efea
to
c084594
Compare
It looks like they are created but somehow only the tests (the ones created last) make it into the index. |
7e6791b
to
2dd75a3
Compare
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
|
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
ccffed0
to
58df2d0
Compare
58df2d0
to
97a42e1
Compare
97a42e1
to
aeff309
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM however I'm not seeing the haddocks action in the summary.
nix develop .\#haddockShell --command \ | ||
cabal haddock-project --output=./haddocks --internal --foreign-libraries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄 🎉
Changelog
Context
Fixes the same issue which happened in cardano-api repo:
This PR copies changes from cardano-api from:
Sample workflow run with generated haddocks (attached as an artifact): https://github.com/IntersectMBO/cardano-cli/actions/runs/9796004207
Checklist