Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate cardano-api changes for fixed Show and Eq instances for Proposal type #72

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Jul 12, 2023

Changelog

- description: |
    Propagate `Show` & `Eq`  `Proposal` instances to cli
  # no-changes: the API has not changed
  # compatible: the API has changed but is non-breaking
  # breaking: the API has changed in a breaking way
  compatibility: no-api-changes
  # feature: the change implements a new feature in the API
  # bugfix: the change fixes a bug in the API
  # test: the change fixes modifies tests
  # maintenance: the change involves something other than the API
  # If more than one is applicable, it may be put into a list.
  type: bugfix

Context

Requires: IntersectMBO/cardano-api#115
Integration checks: https://github.com/input-output-hk/fusion-flamingo/pull/13/checks

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@carbolymer carbolymer force-pushed the mgalazyn/fix/fix-eq-show-proposal-type branch from 7fa43c7 to cf66ff2 Compare July 13, 2023 13:22
@carbolymer carbolymer marked this pull request as ready for review July 13, 2023 13:22
@carbolymer carbolymer requested review from a team, Jimbo4350 and newhoggy as code owners July 13, 2023 13:22
@Jimbo4350 Jimbo4350 self-requested a review July 13, 2023 18:50
@carbolymer carbolymer added this pull request to the merge queue Jul 14, 2023
Merged via the queue into main with commit e5030d9 Jul 14, 2023
@carbolymer carbolymer deleted the mgalazyn/fix/fix-eq-show-proposal-type branch July 14, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants