Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate experimental api #853

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Jul 31, 2024

Changelog

- description: |
    Bump CHaP
    Propagate experimental api to `transaction build` internals
    Deprecate pre-Conway eras for `transaction build`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@Jimbo4350 Jimbo4350 force-pushed the jordan/propagate-experimental-api branch 2 times, most recently from 823ceae to dd833a6 Compare August 12, 2024 16:21
@Jimbo4350 Jimbo4350 force-pushed the jordan/propagate-experimental-api branch 5 times, most recently from 3123577 to 0248fc5 Compare September 5, 2024 18:41
@Jimbo4350 Jimbo4350 marked this pull request as ready for review September 5, 2024 18:42
@Jimbo4350 Jimbo4350 force-pushed the jordan/propagate-experimental-api branch 2 times, most recently from e82f889 to 36c6e5c Compare September 5, 2024 18:45
Copy link
Contributor

@palas palas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@@ -759,7 +772,7 @@ runTxBuildRaw
proposals
mCurrentTreasuryValueAndDonation

first TxCmdTxBodyError $ createAndValidateTransactionBody sbe txBodyContent
first TxCmdTxBodyError $ createTransactionBody sbe txBodyContent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine this is correct, but I don't know why we are not validating here anymore

Propagate experimental api to `transaction build` internals
Deprecate pre-Conway eras for `transaction build`
@Jimbo4350 Jimbo4350 force-pushed the jordan/propagate-experimental-api branch from 1285b4e to 22b2b9b Compare September 5, 2024 19:59
@Jimbo4350 Jimbo4350 mentioned this pull request Sep 5, 2024
3 tasks
@Jimbo4350 Jimbo4350 added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit 26051f0 Sep 5, 2024
25 checks passed
@Jimbo4350 Jimbo4350 deleted the jordan/propagate-experimental-api branch September 5, 2024 21:44
@Jimbo4350 Jimbo4350 mentioned this pull request Sep 6, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants