-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate experimental api #853
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
force-pushed
the
jordan/propagate-experimental-api
branch
2 times, most recently
from
August 12, 2024 16:21
823ceae
to
dd833a6
Compare
Jimbo4350
force-pushed
the
jordan/propagate-experimental-api
branch
5 times, most recently
from
September 5, 2024 18:41
3123577
to
0248fc5
Compare
Jimbo4350
requested review from
a team,
newhoggy,
carbolymer,
smelc,
palas,
kevinhammond and
disassembler
as code owners
September 5, 2024 18:42
Jimbo4350
force-pushed
the
jordan/propagate-experimental-api
branch
2 times, most recently
from
September 5, 2024 18:45
e82f889
to
36c6e5c
Compare
palas
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
@@ -759,7 +772,7 @@ runTxBuildRaw | |||
proposals | |||
mCurrentTreasuryValueAndDonation | |||
|
|||
first TxCmdTxBodyError $ createAndValidateTransactionBody sbe txBodyContent | |||
first TxCmdTxBodyError $ createTransactionBody sbe txBodyContent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagine this is correct, but I don't know why we are not validating here anymore
Jimbo4350
force-pushed
the
jordan/propagate-experimental-api
branch
from
September 5, 2024 19:59
1285b4e
to
22b2b9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist