Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it build with ghc 9.10 #855

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Make it build with ghc 9.10 #855

merged 3 commits into from
Aug 9, 2024

Conversation

erikd
Copy link
Contributor

@erikd erikd commented Aug 1, 2024

Changelog

- description: |
    Make it build with ghc 9.10
# uncomment types applicable to the change:
  type:
  - maintenance    # not directly related to the code

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@erikd erikd marked this pull request as draft August 1, 2024 07:42
@erikd erikd self-assigned this Aug 1, 2024
@erikd erikd marked this pull request as ready for review August 2, 2024 06:59
erikd
erikd commented Aug 2, 2024
View reviewed changes
cabal.project Outdated
, cardano-api:plutus-ledger-api
, cardano-api:prettyprinter-configurable
, cardano-api:base

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will let the node team decide whether the above needs to be fixed before this can be merged.

carbolymer
carbolymer reviewed Aug 2, 2024
View reviewed changes
cabal.project Outdated Show resolved Hide resolved
Jimbo4350
Jimbo4350 requested changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@erikd erikd force-pushed the erikd/ghc-9.10 branch 3 times, most recently from a374f02 to ce4c19b Compare August 8, 2024 06:26
@erikd erikd enabled auto-merge August 9, 2024 07:07
carbolymer
carbolymer reviewed Aug 9, 2024
View reviewed changes
.github/workflows/haskell.yml
@@ -20,7 +20,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ghc: ["9.6", "9.8"]
ghc: ["9.6", "9.8", "9.10"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If our next GHC target after 8.10 is 9.6, I'm wondering if we need both 9.8 and 9.10 here?

@erikd erikd added this pull request to the merge queue Aug 9, 2024
Merged via the queue into main with commit 3435070 Aug 9, 2024
25 checks passed
@erikd erikd deleted the erikd/ghc-9.10 branch August 9, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbolymer carbolymer carbolymer approved these changes

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@smelc smelc Awaiting requested review from smelc smelc is a code owner

@palas palas Awaiting requested review from palas palas is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

Assignees

@erikd erikd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erikd @carbolymer @Jimbo4350