-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy commands #905
Merged
Merged
+9,473
−18,644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
force-pushed
the
jordan/deprecate-legacy-commands
branch
from
September 19, 2024 22:17
c0fd909
to
31dcc96
Compare
Merged
3 tasks
Jimbo4350
force-pushed
the
jordan/deprecate-legacy-commands
branch
4 times, most recently
from
September 20, 2024 17:19
1018029
to
22f0c81
Compare
Jimbo4350
requested review from
newhoggy,
carbolymer,
smelc,
palas,
kevinhammond and
disassembler
as code owners
September 20, 2024 17:19
carbolymer
approved these changes
Sep 20, 2024
Comment on lines
53
to
55
-- There are name clashes between Shelley commands and the Byron backwards | ||
-- compat commands (e.g. "genesis"), and we need to prefer the Shelley ones | ||
-- so we list it first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment needs updating
Jimbo4350
force-pushed
the
jordan/deprecate-legacy-commands
branch
2 times, most recently
from
September 23, 2024 13:56
f74ae10
to
51adbc9
Compare
Don't merge until QA signs off cc: @mkoura |
Looking good 👍 I modified cardano-node-tests and cardano-clusterlib-py to work with the change (and stay compatible with older cardano-cli releases), and all regression tests passed. |
mkoura
approved these changes
Sep 24, 2024
Set default top level era to Conway
Jimbo4350
force-pushed
the
jordan/deprecate-legacy-commands
branch
from
September 26, 2024 11:09
51adbc9
to
cf70d78
Compare
- Cardano.CLI.Legacy.Commands.Key - Cardano.CLI.Legacy.Commands.Transaction - Cardano.CLI.Legacy.Commands.Query - Cardano.CLI.Legacy.Commands.TextView - Cardano.CLI.Legacy.Commands.StakePool - Cardano.CLI.Legacy.Commands.StakeAddress - Cardano.CLI.Legacy.Commands.Node - Cardano.CLI.Legacy.Options.Key - Cardano.CLI.Legacy.Commands.Address - Cardano.CLI.Legacy.Run.Transaction - Cardano.CLI.Legacy.Run.TextView - Cardano.CLI.Legacy.Run.StakePool - Cardano.CLI.Legacy.Run.StakeAddress - Cardano.CLI.Legacy.Run.Address - Cardano.CLI.Legacy.Run.Key - Cardano.CLI.Legacy.Run.Node - Cardano.CLI.Legacy.Run.Query
Jimbo4350
force-pushed
the
jordan/deprecate-legacy-commands
branch
from
September 26, 2024 11:25
cf70d78
to
bf24a35
Compare
Jimbo4350
force-pushed
the
jordan/deprecate-legacy-commands
branch
from
September 26, 2024 11:34
bf24a35
to
935cea1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
cardano-cli
's command line has changed as follows:Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist