Skip to content

Conversation

Lucsanszky
Copy link
Contributor

@Lucsanszky Lucsanszky commented Sep 1, 2025

Description

Follow-up to #5220 and #5137

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

For some reason, these tests fail if we use certificates with deposits,
so as a temporary measure we will avoid using deposits in these cases.

Related: #4571
No longer necessary since the introduction of `genRegTxCert`,
`genUnRegTxCert` `ShelleyEraImp` typeclass methods.
This reverts commit 9a06817
and related changes.
No longer necessary since the introduction of `genRegTxCert`,
`genUnRegTxCert` `ShelleyEraImp` typeclass methods.
@Lucsanszky Lucsanszky force-pushed the ldan/shelley-delegspec branch from d5e6d83 to 1a163af Compare September 19, 2025 12:27
@Lucsanszky Lucsanszky marked this pull request as ready for review September 19, 2025 12:32
@Lucsanszky Lucsanszky requested a review from a team as a code owner September 19, 2025 12:32
@Lucsanszky Lucsanszky changed the base branch from master to ldan/imptest-improvements September 19, 2025 12:36
@Lucsanszky Lucsanszky force-pushed the ldan/imptest-improvements branch 7 times, most recently from 9aa07d4 to b64db3a Compare September 26, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant