-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wb | cardano-topology #5555
Merged
Merged
wb | cardano-topology #5555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmaste
force-pushed
the
bench-cardano-topology
branch
from
December 8, 2023 20:27
9c7d94c
to
578e64e
Compare
fmaste
force-pushed
the
bench-cardano-topology
branch
9 times, most recently
from
January 9, 2024 03:53
df817b4
to
f2f0cb7
Compare
fmaste
force-pushed
the
bench-cardano-topology
branch
3 times, most recently
from
January 11, 2024 15:04
9f84a10
to
ed63172
Compare
fmaste
force-pushed
the
bench-cardano-topology
branch
from
January 12, 2024 13:26
ed63172
to
871af0d
Compare
mgmeier
reviewed
Jan 12, 2024
fmaste
force-pushed
the
bench-cardano-topology
branch
from
January 12, 2024 16:44
871af0d
to
7a739b1
Compare
fmaste
force-pushed
the
bench-cardano-topology
branch
from
January 12, 2024 16:51
7a739b1
to
0c99ed5
Compare
fmaste
force-pushed
the
bench-cardano-topology
branch
from
January 12, 2024 18:53
0c99ed5
to
f1298d4
Compare
mgmeier
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work and thank you @fmaste !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cardano-topology
project now has a library and unit testing.vault
tokens.Checklist
See Runnings tests for more details
CHANGELOG.md
for affected package.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7
Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.