Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wb | cardano-topology #5555

Merged
merged 8 commits into from
Jan 12, 2024
Merged

wb | cardano-topology #5555

merged 8 commits into from
Jan 12, 2024

Conversation

fmaste
Copy link
Contributor

@fmaste fmaste commented Nov 28, 2023

Description

  • Workbench's cardano-topology project now has a library and unit testing.
  • The executable can build topologies for "torus" and "torus-dense" independently.
  • AWS regions can be completely specified, "us-east-1" instead of "US", when defining the profile.
  • Fixes for Nomad to support plutus profiles.
  • Fixes for Nomad to support P2P.
  • Fixes for healthchecks to support P2P.
  • Minor changes to healthchecks and vault tokens.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@fmaste fmaste force-pushed the bench-cardano-topology branch 9 times, most recently from df817b4 to f2f0cb7 Compare January 9, 2024 03:53
@fmaste fmaste force-pushed the bench-cardano-topology branch 3 times, most recently from 9f84a10 to ed63172 Compare January 11, 2024 15:04
@fmaste fmaste changed the title Bench cardano-topology wb | cardano-topology Jan 11, 2024
@fmaste fmaste marked this pull request as ready for review January 11, 2024 15:46
@fmaste fmaste requested a review from mgmeier January 12, 2024 14:03
Copy link
Contributor

@mgmeier mgmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work and thank you @fmaste !

@mgmeier mgmeier added this pull request to the merge queue Jan 12, 2024
Merged via the queue into master with commit 072ae58 Jan 12, 2024
20 checks passed
@mgmeier mgmeier deleted the bench-cardano-topology branch January 12, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants