Add governance Info action test #5629
Conversation
carbolymer
force-pushed
the
mgalazyn/test/governance-info-action
branch
2 times, most recently
from
396e4a3
to
e67fe96
Compare
carbolymer
force-pushed
the
mgalazyn/test/governance-info-action
branch
4 times, most recently
from
cb8da1f
to
f9b1c99
Compare
| let actions = | ||
| map snd | ||
| $ filter ((== govActionIdx) . fst) | ||
| $ map (first (\gai -> do | ||
| let (L.GovActionIx i) = L.gaidGovActionIx gai | ||
| i | ||
| )) | ||
| $ Map.assocs $ L.proposalsGovActionStates proposals | ||
| case actions of | ||
| [L.GovActionState{L.gasDRepVotes=votes}] | ||
| | length votes == 3 -> ias{hasReceivedVotes = True} |
There was a problem hiding this comment.
Quite readable for what it does, nice ❤️
There was a problem hiding this comment.
Compared with the existing cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/LedgerEvents/Gov/ProposeNewConstitution.hs and this one works similarly 👍
One question though: don't we want to use query gov-state (or alike) instead of using foldBlocks at the end? I thought we were moving away from this foldBlock pattern, in its existing shape at least.
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/LedgerEvents/Gov/InfoAction.hs
Outdated
Show resolved
Hide resolved
| void $ H.execCli' execConfig | ||
| [ "conway", "query", "utxo" | ||
| , "--address", Text.unpack $ paymentKeyInfoAddr $ head wallets | ||
| , "--cardano-mode" | ||
| , "--testnet-magic", show @Int testnetMagic | ||
| , "--out-file", work </> "utxo-1.json" | ||
| ] | ||
|
|
||
| txin1 <- do | ||
| utxoJson <- H.leftFailM . H.readJsonFile $ work </> "utxo-1.json" | ||
| UTxO utxo <- H.noteShowM $ decodeEraUTxO sbe utxoJson | ||
| H.noteShow =<< H.headM (Map.keys utxo) |
There was a problem hiding this comment.
Could you make this a function? This is used a number of times in this test, but also in others.
Making it a function would reduce the test's length and make the important part stand out a bit more.
@smelc an info action is not visible in the ledger state, not sure about gov-state. I can't use |
| {-# LANGUAGE ScopedTypeVariables #-} | ||
| {-# LANGUAGE TypeApplications #-} | ||
|
|
||
| {-# OPTIONS_GHC -Wno-unrecognised-pragmas #-} |
There was a problem hiding this comment.
afair HLint was complaining about !! 0, which is fine here in my opinion
| ] | ||
|
|
||
| -- Create Drep registration certificates | ||
| let drepCertFile :: Int -> FilePath |
There was a problem hiding this comment.
This is fine for now but we can inject the dreps into the genesis after the next release of api and cli. We will probably want a single standalone test that makes sure the cli can generate the certificates and successfully submit them.
carbolymer
force-pushed
the
mgalazyn/test/governance-info-action
branch
from
0bcf75e
to
dfc7f4c
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Description
Add a governance info testnet scenario.
Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-8.10.7andghc-9.2.7Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.