Use cardano-cli create-testnet-data instead of create-staked #5630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
commented
Jan 9, 2024
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Cli/KesPeriodInfo.hs
Outdated
Show resolved
Hide resolved
Jimbo4350
commented
Jan 9, 2024
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Cli/KesPeriodInfo.hs
Outdated
Show resolved
Hide resolved
Jimbo4350
force-pushed
the
jordan/convert-to-create-testnet-data
branch
4 times, most recently
from
f6b7c3e
to
c801e4e
Compare
carbolymer
reviewed
Jan 10, 2024
Comment on lines
+216
to
+219
| convertToEraString (AnyCardanoEra e) = | ||
| case e of | ||
| ConwayEra -> "conway" | ||
| BabbageEra -> "babbage" | ||
| AlonzoEra -> "alonzo" | ||
| MaryEra -> "mary" | ||
| AllegraEra -> "allegra" | ||
| ShelleyEra -> "shelley" | ||
| ByronEra -> "byron" |
There was a problem hiding this comment.
You can use this instead:
Suggested change
| convertToEraString (AnyCardanoEra e) = | |
| case e of | |
| ConwayEra -> "conway" | |
| BabbageEra -> "babbage" | |
| AlonzoEra -> "alonzo" | |
| MaryEra -> "mary" | |
| AllegraEra -> "allegra" | |
| ShelleyEra -> "shelley" | |
| ByronEra -> "byron" | |
| convertToEraString = map toLower . docToString . pshow |
There was a problem hiding this comment.
This actually gives "conwayera". I'm reverting to what I originally had.
There was a problem hiding this comment.
Right. Sorry I meant convertToEraString = map toLower . docToString . pretty.
carbolymer
reviewed
Jan 10, 2024
| @@ -89,7 +89,7 @@ isLinux = os == "linux" | |||
|
|
|||
| -- | Submit the desired epoch to wait to. | |||
| waitUntilEpoch | |||
| :: (MonadCatch m, MonadIO m, MonadTest m) | |||
| :: (MonadCatch m, MonadIO m, MonadTest m, HasCallStack) | |||
There was a problem hiding this comment.
Nice! HasCallStack is always useful.
carbolymer
reviewed
Jan 10, 2024
...ano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Cli/Babbage/LeadershipSchedule.hs
Outdated
Show resolved
Hide resolved
carbolymer
approved these changes
Jan 10, 2024
smelc
reviewed
Jan 10, 2024
smelc
reviewed
Jan 10, 2024
...et/test/cardano-testnet-test/Cardano/Testnet/Test/LedgerEvents/Gov/ProposeNewConstitution.hs
Show resolved
Hide resolved
Jimbo4350
force-pushed
the
jordan/convert-to-create-testnet-data
branch
4 times, most recently
from
e655ba3
to
6ef266e
Compare
Jimbo4350
force-pushed
the
jordan/convert-to-create-testnet-data
branch
2 times, most recently
from
ebee449
to
454a8d0
Compare
3 tasks
Jimbo4350
force-pushed
the
jordan/convert-to-create-testnet-data
branch
from
454a8d0
to
db7229b
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to invalid changes in the merge commit
create-testnet-data
…o be compatible with create-testnet-data
queryTip and waitUntilEpoch
smelc
force-pushed
the
jordan/convert-to-create-testnet-data
branch
from
db7229b
to
1d10a76
Compare
|
I rebased the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
create-testnet-databecausecreate-stakedwas somewhat rushed intocardano-cli. We plan to improve and potentially make breaking changes tocreate-testnet-dataand we want to avoid breaking existing functionality increate-staked.Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-8.10.7andghc-9.2.7Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.