trace-dispatcher: documentation #5635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NadiaYvette
approved these changes
Jan 11, 2024
jutaro
force-pushed
the
jutaro/tracer-docs
branch
from
31ee69c
to
64158f8
Compare
mgmeier
reviewed
Jan 16, 2024
|
|
||
| ### Privacy | ||
| documentFor :: Namespace a -> Maybe Text |
There was a problem hiding this comment.
No default implementation like const Nothing? Do I have to provide that explicitly as a dev?
There was a problem hiding this comment.
Has currently no default implementation. The idea was to motivate the writing of docu, but this can be changed?
|
|
||
| 2. __Trace-Forward Tracer:__ This is a network-only sink dedicated to forwarding messages using typed protocols over TCP or local sockets. It exclusively handles public traces and should be instantiated only once per application. |
There was a problem hiding this comment.
Is forwarding over TCP an option, or has that been removed? A quick look of how I'd configure this came up empty...
There was a problem hiding this comment.
I can't see the relation of your question to this part. The configuration of the forwarder should be part of the other two documents: "cardano-tracer manual" and "quick start of new tracing for admins"
jutaro
force-pushed
the
jutaro/tracer-docs
branch
2 times, most recently
from
ddd635a
to
99e94d4
Compare
jutaro
force-pushed
the
jutaro/tracer-docs
branch
from
99e94d4
to
dca4b8c
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
jutaro
force-pushed
the
jutaro/tracer-docs
branch
3 times, most recently
from
576ab7c
to
8afc2da
Compare
jutaro
force-pushed
the
jutaro/tracer-docs
branch
from
8afc2da
to
342933a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete rewrite of trace-dispatcher documentation.