Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cardano-cli 8.19 #5644

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Jan 19, 2024

Description

Update:

  • cardano-cli 8.19
  • cardano-api 8.37.1
  • hedgehog-extras 0.6

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@carbolymer carbolymer force-pushed the mgalazyn/chore/update-cardano-cli-8.19 branch 2 times, most recently from 5a2a76a to a7ddc5a Compare January 19, 2024 09:42
@@ -89,5 +89,5 @@ test-suite chairman-tests
ghc-options: -threaded -rtsopts -with-rtsopts=-N -with-rtsopts=-T

build-tool-depends: cardano-node:cardano-node
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chairman is in the same repo as node. If they're built together, it will get the version from the repo. I'm not aware about any other build method.

@@ -89,5 +89,5 @@ test-suite chairman-tests
ghc-options: -threaded -rtsopts -with-rtsopts=-N -with-rtsopts=-T

build-tool-depends: cardano-node:cardano-node
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chairman is in the same repo as node. If they're built together, it will get the version from the repo. I'm not aware about any other build method.

@newhoggy newhoggy force-pushed the mgalazyn/chore/update-cardano-cli-8.19 branch from a7ddc5a to 43990ab Compare January 20, 2024 03:42
@carbolymer carbolymer added this pull request to the merge queue Jan 20, 2024
Merged via the queue into master with commit 818b23c Jan 20, 2024
20 checks passed
@carbolymer carbolymer deleted the mgalazyn/chore/update-cardano-cli-8.19 branch January 20, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants