Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8.8.0-pre #5648

Merged
merged 1 commit into from
Feb 8, 2024
Merged

8.8.0-pre #5648

merged 1 commit into from
Feb 8, 2024

Conversation

zliu41
Copy link
Member

@zliu41 zliu41 commented Jan 25, 2024

No description provided.

@zliu41 zliu41 marked this pull request as draft January 25, 2024 01:56
@zliu41 zliu41 mentioned this pull request Jan 25, 2024
Closed
@zliu41 zliu41 force-pushed the zliu41/880pre branch 4 times, most recently from 1d91957 to 7091e82 Compare February 1, 2024 20:44
@carbolymer carbolymer force-pushed the zliu41/880pre branch 4 times, most recently from accc8c4 to 9b0aee6 Compare February 7, 2024 09:34
@zliu41 zliu41 marked this pull request as ready for review February 7, 2024 17:02
amesgen
amesgen reviewed Feb 7, 2024
View reviewed changes
Copy link
Member

@amesgen amesgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The minor changes done here due to changes in Consensus seem good, only a minor comment 👍

cardano-node/src/Cardano/Tracing/OrphanInstances/Consensus.hs Outdated Show resolved Hide resolved
cardano-node/src/Cardano/Node/Tracing/Tracers/Consensus.hs Outdated Show resolved Hide resolved
Jimbo4350
Jimbo4350 reviewed Feb 7, 2024
View reviewed changes
cabal.project Outdated Show resolved Hide resolved
cardano-node/cardano-node.cabal Outdated Show resolved Hide resolved
cardano-node/src/Cardano/Node/Tracing/Render.hs Outdated Show resolved Hide resolved
@zliu41 zliu41 changed the title 8.8.0-pre integration 8.8.0-pre Feb 8, 2024
@smelc smelc mentioned this pull request Feb 8, 2024
Closed
@disassembler disassembler added this pull request to the merge queue Feb 8, 2024
Merged via the queue into master with commit 4bb2048 Feb 8, 2024
18 checks passed
@disassembler disassembler deleted the zliu41/880pre branch February 8, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 left review comments

@amesgen amesgen amesgen left review comments

@carbolymer carbolymer carbolymer approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zliu41 @carbolymer @Jimbo4350 @amesgen @disassembler