Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index state #5869

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Update index state #5869

merged 1 commit into from
Jun 6, 2024

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented May 30, 2024

Description

We no longer need the constraint on io-classes-mtl and wai-extra.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@newhoggy newhoggy force-pushed the newhoggy/update-index-state branch from de93034 to e3da8b3 Compare May 30, 2024 22:33
@newhoggy newhoggy marked this pull request as ready for review May 30, 2024 22:34
@newhoggy newhoggy requested a review from a team as a code owner May 30, 2024 22:34
smelc
smelc previously requested changes May 31, 2024
Copy link
Contributor

@smelc smelc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lock files need to be updated

@newhoggy newhoggy requested a review from smelc June 1, 2024 00:06
@newhoggy newhoggy force-pushed the newhoggy/update-index-state branch from e3da8b3 to d3d25a9 Compare June 1, 2024 00:10
@newhoggy newhoggy requested review from a team as code owners June 1, 2024 00:10
@newhoggy newhoggy dismissed smelc’s stale review June 1, 2024 00:21

Comments addressed

@newhoggy newhoggy force-pushed the newhoggy/update-index-state branch 2 times, most recently from 5d52d75 to 93f9d14 Compare June 1, 2024 00:22
@newhoggy newhoggy added this pull request to the merge queue Jun 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 2, 2024
@newhoggy newhoggy force-pushed the newhoggy/update-index-state branch from 93f9d14 to 4f3a31d Compare June 2, 2024 06:07
@@ -1,6 +1,7 @@
name: Actionlint

on:
merge_group:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@newhoggy> why this change?

@@ -7,6 +7,7 @@ name: Shellcheck
# is consistent with the one of developers.

on:
merge_group:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as @smelc 's question for actionlint.yaml. Seems redundant for merge queue.

@carbolymer carbolymer force-pushed the newhoggy/update-index-state branch from 44bb873 to 97775df Compare June 6, 2024 09:57
@newhoggy newhoggy enabled auto-merge June 6, 2024 12:44
@newhoggy newhoggy disabled auto-merge June 6, 2024 12:45
@newhoggy
Copy link
Contributor Author

newhoggy commented Jun 6, 2024

Hydra error will be fixed by IntersectMBO/cardano-api#548 so force merging because we want other changes.

@newhoggy newhoggy merged commit ce9ea33 into master Jun 6, 2024
22 of 26 checks passed
@newhoggy newhoggy deleted the newhoggy/update-index-state branch June 6, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants