-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add toplevel changelog #5959
add toplevel changelog #5959
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks!
@aleeusgr Can you sign your commits please? That's our requirement for all changes in the node. https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
e8b9d30
to
2e72abd
Compare
2e72abd
to
1b24c1d
Compare
@carbolymer hello! I am confused a bit, I did the following: now the commit message contains my name and email, does it mean its signed? Thank you! |
|
Signed-off-by: Alex <alexeusgr@gmail.com>
1b24c1d
to
007dc96
Compare
Thanks! |
@aleeusgr I think you just need to upload your public key to github |
@carbolymer thanks! Added GPG key to my GitHub account. KeyID: 6A7D30C3EFF7B815 |
Description
Add your description here, if it fixes a particular issue please provide a
link
to the issue.
closes #5874
Checklist
See Runnings tests for more details
CHANGELOG.md
for affected package.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7
Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.