Hash check in transaction build tests #6023

palas · 2024-10-24T14:28:23Z

DO NOT MERGE: Need to remove the SRP stanza

Description

This PR updates tests in cardano-testnet to work with the new check of anchor hashes added to transaction build (see IntersectMBO/cardano-cli#951).

Related PRs

[cardano-api] Add function to extract anchor data from certificate cardano-api#664
[cardano-cli] Add anchor hash checks to transaction build cardano-cli#951

Checklist

Commit sequence broadly makes sense and commits have useful messages
New tests are added if needed and existing tests are updated. These may include:
- golden tests
- property tests
- roundtrip tests
- integration tests
  See Runnings tests for more details
Any changes are noted in the CHANGELOG.md for affected package
The version bounds in .cabal files are updated
CI passes. See note on CI. The following CI checks are required:
- Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
- Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
- Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
Self-reviewed the diff

Jimbo4350

LGTM! A few suggestions.

Jimbo4350 · 2024-10-25T16:02:49Z

cardano-testnet/src/Testnet/Process/Run.hs

+-- | Adds environment variables to an 'ExecConfig' that may already
+-- have some environment variables set. This is done by prepending the new
+-- environment variables to the existing ones.
+addEnvVarsToConfig :: H.ExecConfig -> [(String, String)] -> H.ExecConfig


We should modify mkExecConfig to accept a list of environment variables.

In this case, it is good to have it locally modified though, cause it is only relevant inside the serveFilesWhile

Or we could expose lenses for ExecConfig for that purpose?

Jimbo4350 · 2024-10-25T16:07:36Z

cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Gov/ProposeNewConstitution.hs

-    , "--out-file", txbodyFp
+  -- Create temporary HTTP server with files required by the call to `cardano-cli`
+  -- In this case, the server emulates an IPFS gateway
+  serveFilesWhile


What does a failure here look like?

serveFilesWhile doesn't seem to interfere with the output in case of failure, you can see an example here: https://github.com/IntersectMBO/cardano-node/pull/6023/checks?check_run_id=32024584074

Is that what you meant?

That failure is coming from line 127. Can you induce one inside the serveFilesWhile argument, e.g. in line 186?

Jimbo4350 · 2024-10-25T16:49:53Z

cardano-testnet/test/cardano-testnet-test/files/sample-constitution-anchor

@@ -0,0 +1,50 @@
+Preamble
+
+We, the zaniest inhabitants of the peculiar and bewildering land of Barataria, in honor of our illustrious Governor, Sancho Panza, renowned for his comically charming ordinances, do hereby present this Constitution to tickle your fancy and uphold the values of laughter, merriment, and the pursuit of hilarity for all our citizens.


No idea, I downloaded it from the shortened link that was there before: https://tinyurl.com/2pahcy6z. It seems an old gist by @carloslodelar. @CarlosLopezDeLara, was that you? do you know the origin of it?

cardano-testnet/cardano-testnet.cabal

carbolymer · 2024-10-30T09:13:46Z

cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Gov/Transaction/HashMismatch.hs

+
+        H.note_ stderrOutput
+
+        H.assert ("Hashes do not match!" `Text.isInfixOf` Text.pack stderrOutput)


Suggestion: use assertWith for more verbose failure reporting.

carbolymer · 2024-10-30T09:18:16Z

cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Gov/Transaction/HashMismatch.hs

+  void $ execCli' execConfig
+    [ eraName, "stake-address", "registration-certificate"
+    , "--stake-verification-key-file", stakeVkeyFp
+    , "--key-reg-deposit-amt", show @Int 0 -- TODO: why this needs to be 0????


This can't be 0 now. You can get the right value using:

cardano-node/cardano-testnet/src/Testnet/Components/Query.hs

Line 584 in 02cd604

getKeyDeposit :: (H.MonadAssertion m, MonadTest m, MonadIO m)

There's a helper function for creating stake key registration certs: https://github.com/IntersectMBO/cardano-node/blob/master/cardano-testnet/src/Testnet/Process/Cli/SPO.hs#L178

carbolymer · 2024-10-30T09:26:22Z

cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Gov/Transaction/HashMismatch.hs

+            execConfig'
+            [ eraName, "governance", "action", "create-info"
+            , "--testnet"
+            , "--governance-action-deposit", show @Int 1_000_000 -- TODO: Get this from the node


use getMinGovActionDeposit instead of hardcoding a value

…checks

…e new checks

… checks

palas added DO NOT MERGE cardano-testnet labels Oct 24, 2024

palas self-assigned this Oct 24, 2024

palas requested a review from a team as a code owner October 24, 2024 14:28

palas linked an issue Oct 24, 2024 that may be closed by this pull request

[FR] - Add File Hash Validation when Building Transaction IntersectMBO/cardano-cli#882

Closed

palas mentioned this pull request Oct 25, 2024

Add anchor hash checks to transaction build IntersectMBO/cardano-cli#951

Open

3 tasks

Jimbo4350 approved these changes Oct 25, 2024

View reviewed changes

palas force-pushed the hash-check-in-transaction-build-tests branch 2 times, most recently from 25cd53a to 7e14eb8 Compare October 28, 2024 22:07

palas mentioned this pull request Oct 29, 2024

Add function to extract anchor data from certificate IntersectMBO/cardano-api#664

Merged

3 tasks

palas requested review from a team as code owners October 29, 2024 11:05

palas force-pushed the hash-check-in-transaction-build-tests branch 7 times, most recently from d641b5f to e3fb8f9 Compare October 29, 2024 17:22

carbolymer reviewed Oct 30, 2024

View reviewed changes

palas added 8 commits October 31, 2024 15:06

Add temporary SRP stanza

95bb7cf

Update hprop_ledger_events_info_action to work with the new checks

a722af1

Update hprop_constitutional_committee_add_new to work with the new …

e061d41

…checks

Update hprop_ledger_events_propose_new_constitution to work with th…

a839d37

…e new checks

Update makeActivityChangeProposal to work with the new checks

0cc8eed

Update hprop_ledger_events_treasury_withdrawal to work with the new…

3133042

… checks

Add test to check transaction build fails with wrong hash

9924169

Patch for CI

312398c

Renamed TransactionBuildWrongHash to Transaction.HashMismatch

6aea891

palas force-pushed the hash-check-in-transaction-build-tests branch from e3fb8f9 to 6aea891 Compare October 31, 2024 14:19

palas added the next-update label Nov 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hash check in transaction build tests #6023

Hash check in transaction build tests #6023

palas commented Oct 24, 2024 •

edited

Loading

Jimbo4350 left a comment

Jimbo4350 Oct 25, 2024

palas Oct 25, 2024

carbolymer Oct 30, 2024 •

edited

Loading

Jimbo4350 Oct 25, 2024

palas Oct 25, 2024

carbolymer Oct 30, 2024 •

edited

Loading

Jimbo4350 Oct 25, 2024

palas Oct 25, 2024

carbolymer Oct 30, 2024

carbolymer Oct 30, 2024 •

edited

Loading

carbolymer Oct 30, 2024 •

edited

Loading

		@@ -0,0 +1,50 @@
		Preamble

		We, the zaniest inhabitants of the peculiar and bewildering land of Barataria, in honor of our illustrious Governor, Sancho Panza, renowned for his comically charming ordinances, do hereby present this Constitution to tickle your fancy and uphold the values of laughter, merriment, and the pursuit of hilarity for all our citizens.


		H.note_ stderrOutput

		H.assert ("Hashes do not match!" `Text.isInfixOf` Text.pack stderrOutput)

Hash check in transaction build tests #6023

Are you sure you want to change the base?

Hash check in transaction build tests #6023

Conversation

palas commented Oct 24, 2024 • edited Loading

Description

Related PRs

Checklist

Jimbo4350 left a comment

Choose a reason for hiding this comment

Jimbo4350 Oct 25, 2024

Choose a reason for hiding this comment

palas Oct 25, 2024

Choose a reason for hiding this comment

carbolymer Oct 30, 2024 • edited Loading

Choose a reason for hiding this comment

Jimbo4350 Oct 25, 2024

Choose a reason for hiding this comment

palas Oct 25, 2024

Choose a reason for hiding this comment

carbolymer Oct 30, 2024 • edited Loading

Choose a reason for hiding this comment

Jimbo4350 Oct 25, 2024

Choose a reason for hiding this comment

palas Oct 25, 2024

Choose a reason for hiding this comment

carbolymer Oct 30, 2024

Choose a reason for hiding this comment

carbolymer Oct 30, 2024 • edited Loading

Choose a reason for hiding this comment

carbolymer Oct 30, 2024 • edited Loading

Choose a reason for hiding this comment

palas commented Oct 24, 2024 •

edited

Loading

carbolymer Oct 30, 2024 •

edited

Loading

carbolymer Oct 30, 2024 •

edited

Loading

carbolymer Oct 30, 2024 •

edited

Loading

carbolymer Oct 30, 2024 •

edited

Loading