plutus-tx: add red-black tree implementation for Maps, again #5697
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It still sucks. It manages to sometimes be better, which is cool, but overall it's quite a lot worse and it uses a lot of space. So still not worth it unless we somehow figure out a way to make it much faster.
Amusingly, with this version the dumb equality function is almost as good as @effectfully 's clever one. Also
toList
produces an ordered list, so maybe we could optimize equality further, IDK.I spent a bit of time on it to get it this fast, mostly fusing things together so we don't do multiple passes.
biFoldr
is the workhorse.Some things I have not tried:
k -> k -> Ordering
instead ofOrd k
, since apparently ourOrd
class has a ton of membersByteString
keysbiFoldr
does effectively by callingsplit
)