[Builtins] Generalize 'evaluateTerm' #7367
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effectfully
commented
Sep 25, 2025
| :: (NFData fun, Pretty fun, PLC.Typeable fun, Eq (BuiltinSemanticsVariant fun)) | ||
| => LedgerApi.EvaluationContext fun | ||
| -> UPLC.Term PLC.NamedDeBruijn PLC.DefaultUni fun () | ||
| -> Benchmarkable |
There was a problem hiding this comment.
This was the goal.
|
|
||
| -- | The execution context for benchmarking. | ||
| evaluationContext :: Either String EvaluationContext | ||
| evaluationContext :: Either String (EvaluationContext PLC.DefaultFun) |
There was a problem hiding this comment.
If we're gonna merge this, we should probably introduce a synonym for EvaltuationContext DefaultFun.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shows how to generalize
evaluateTermso that it works with anyfun.@kwxm It's not a complete PR, let me know if you want me to make it complete or if you just want to pull these changes into your branch or if this is even the right thing / needs changes etc.