Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement kmeans with kmeans++ #24

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Implement kmeans with kmeans++ #24

wants to merge 11 commits into from

Conversation

vberezhnev
Copy link

No description provided.

@vberezhnev vberezhnev force-pushed the feature/mutual-scores-kmeans branch 2 times, most recently from a935134 to 5dba760 Compare October 30, 2024 03:33
@vberezhnev vberezhnev linked an issue Oct 31, 2024 that may be closed by this pull request
Add normalization of mutual stats to meritrank-service "MUTUAL_SCORES" #10
Open
ichorid
ichorid requested changes Nov 2, 2024
View reviewed changes
Copy link
Contributor

@ichorid ichorid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests and remove CI/CD stuff (that is subject to a separate PR). Also, move the k-means algorithm into a separate file.

@vberezhnev
Copy link
Author

@automainint What do you think about moving files like clustering.rs, log.rs, and astar.rs into a separate folder specifically for libraries?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichorid ichorid ichorid requested changes

@automainint automainint Awaiting requested review from automainint

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add normalization of mutual stats to meritrank-service "MUTUAL_SCORES"
3 participants
@vberezhnev @ichorid @automainint