"enemy of my friend" feature and total refactor #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes multiple things in how MeritRank is calculated and implemented: 1. "Friend of my enemy" feature (reverse negs calculation) is removed completely, for the reason it does not affect walks beyond the offender's friend, and thus is useless for prediction. 2. Due to removal of the reverse negs feature, it became possible to greatly simplify and streamline the code 3. Added "enemy of my friend" feature. Walks can now take negative edges, and when a walk passes through a negative edge, it switches to "negative continuation mode": every node passed is now *subtracted* from the total hit count, and the walk can only go through positive edges now. The idea is to get information about what my (and my friends') "enemies" consider their "friends", and downvote that. Note that this method is suspectible to "bait-and-switch" manipulation, as the foe can accumulate a lot of upvotes from me, and then "redirect" it to my friends. This can be solved by time-based graphs, eventually.
ichorid
force-pushed
the
feature/enemy_of_my_friend
branch
from
717c5a4
to
3eeaea6
Compare
automainint
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes multiple things in how MeritRank is calculated and implemented:
Important note:
The change breaks numeric/algorithmic compatibility with Python version, so the corresponding
incrementaltests are disabled, as the data inOUTX.csvdoes not match the algorithm anymore.