Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added internal universal execute method to remove duplicates in logic. #29

Merged
merged 1 commit into from
Sep 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/query_builder/delete.rs
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ impl Delete {
} else {
self.values_.clone()
};
scylla.native_execute(py, query, values, false)
scylla.native_execute(py, Some(query), None, values, false)
}

/// Add to batch
Expand Down
2 changes: 1 addition & 1 deletion src/query_builder/insert.rs
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ impl Insert {
pub fn execute<'a>(&'a self, py: Python<'a>, scylla: &'a Scylla) -> ScyllaPyResult<&'a PyAny> {
let mut query = Query::new(self.build_query()?);
self.request_params_.apply_to_query(&mut query);
scylla.native_execute(py, query, self.values_.clone(), false)
scylla.native_execute(py, Some(query), None, self.values_.clone(), false)
}

/// Add to batch
Expand Down
2 changes: 1 addition & 1 deletion src/query_builder/select.rs
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ impl Select {
) -> ScyllaPyResult<&'a PyAny> {
let mut query = Query::new(self.build_query());
self.request_params_.apply_to_query(&mut query);
scylla.native_execute(py, query, self.values_.clone(), paged)
scylla.native_execute(py, Some(query), None, self.values_.clone(), paged)
}

/// Add to batch
Expand Down
2 changes: 1 addition & 1 deletion src/query_builder/update.rs
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ impl Update {
} else {
values
};
scylla.native_execute(py, query, values, false)
scylla.native_execute(py, Some(query), None, values, false)
}

/// Add to batch
Expand Down
71 changes: 33 additions & 38 deletions src/scylla_cls.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ use openssl::{
x509::X509,
};
use pyo3::{pyclass, pymethods, PyAny, Python};
use scylla::{frame::value::ValueList, query::Query};
use scylla::{frame::value::ValueList, prepared_statement::PreparedStatement, query::Query};

#[pyclass(frozen, weakref)]
#[derive(Clone)]
Expand Down Expand Up @@ -52,7 +52,8 @@ impl Scylla {
pub fn native_execute<'a>(
&'a self,
py: Python<'a>,
query: impl Into<Query> + Send + 'static,
query: Option<impl Into<Query> + Send + 'static>,
prepared: Option<PreparedStatement>,
values: impl ValueList + Send + 'static,
paged: bool,
) -> ScyllaPyResult<&'a PyAny> {
Expand All @@ -64,13 +65,31 @@ impl Scylla {
))?;
// let res = session.query(query, values).await?;
if paged {
Ok(ScyllaPyQueryReturns::IterableQueryResult(
ScyllaPyIterableQueryResult::new(session.query_iter(query, values).await?),
))
match (query, prepared) {
(Some(query), None) => Ok(ScyllaPyQueryReturns::IterableQueryResult(
ScyllaPyIterableQueryResult::new(session.query_iter(query, values).await?),
)),
(None, Some(prepared)) => Ok(ScyllaPyQueryReturns::IterableQueryResult(
ScyllaPyIterableQueryResult::new(
session.execute_iter(prepared, values).await?,
),
)),
_ => Err(ScyllaPyError::SessionError(
"You should pass either query or prepared query.".into(),
)),
}
} else {
Ok(ScyllaPyQueryReturns::QueryResult(ScyllaPyQueryResult::new(
session.query(query, values).await?,
)))
match (query, prepared) {
(Some(query), None) => Ok(ScyllaPyQueryReturns::QueryResult(
ScyllaPyQueryResult::new(session.query(query, values).await?),
)),
(None, Some(prepared)) => Ok(ScyllaPyQueryReturns::QueryResult(
ScyllaPyQueryResult::new(session.execute(&prepared, values).await?),
)),
_ => Err(ScyllaPyError::SessionError(
"You should pass either query or prepared query.".into(),
)),
}
}
})
.map_err(Into::into)
Expand Down Expand Up @@ -275,36 +294,12 @@ impl Scylla {
// in query.
let query_params = parse_python_query_params(params, true)?;
// We need this clone, to safely share the session between threads.
let session_arc = self.scylla_session.clone();
scyllapy_future(py, async move {
let session_guard = session_arc.read().await;
let session = session_guard.as_ref().ok_or(ScyllaPyError::SessionError(
"Session is not initialized.".into(),
))?;
if paged {
let res = match query {
ExecuteInput::Text(text) => session.query_iter(text, query_params).await?,
ExecuteInput::Query(query) => session.query_iter(query, query_params).await?,
ExecuteInput::PreparedQuery(prepared) => {
session.execute_iter(prepared, query_params).await?
}
};
Ok(ScyllaPyQueryReturns::IterableQueryResult(
ScyllaPyIterableQueryResult::new(res),
))
} else {
let res = match query {
ExecuteInput::Text(text) => session.query(text, query_params).await?,
ExecuteInput::Query(query) => session.query(query, query_params).await?,
ExecuteInput::PreparedQuery(prepared) => {
session.execute(&prepared.into(), query_params).await?
}
};
Ok(ScyllaPyQueryReturns::QueryResult(ScyllaPyQueryResult::new(
res,
)))
}
})
let (query, prepared) = match query {
ExecuteInput::Text(txt) => (Some(Query::new(txt)), None),
ExecuteInput::Query(query) => (Some(Query::from(query)), None),
ExecuteInput::PreparedQuery(prep) => (None, Some(PreparedStatement::from(prep))),
};
self.native_execute(py, query, prepared, query_params, paged)
}

/// Execute a batch statement.
Expand Down