Reduce RAM consumption when downdload/upload file to file_size*2 #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… more then file_size*3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation consumes about 3× the file size when uploading to S3 (tested with a 1 GB file, memory usage was ~3.2 GB). Downloading is even worse: s3proxy is consistently killed by the OS OOM killer when trying to download a 1 GB file from S3. At that moment the server had 5–6 GB of free RAM, and s3proxy consumed all of it.
With the changes from this PR, s3proxy consumes about 2× the file size for both uploads and downloads.