Improve robustness of card face matching#114
Open
pappnu wants to merge 1 commit intoInvestigamer:mainfrom
Open
Improve robustness of card face matching#114pappnu wants to merge 1 commit intoInvestigamer:mainfrom
pappnu wants to merge 1 commit intoInvestigamer:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the layout fall back to first card face for multi-faced cards if none of the card faces match the image file's name.
When rendering Adventure cards, even a slight typo in the image file's name causes the layout to use incorrect "front face" data even though the correct card is fetched from Scryfall thanks to the set code and collector number, if specified. For Adventure cards we always want to match the first card face since they don't have faces in the same sense as Transform and other similar cards, so defaulting to the first face works well for them. Properly dual faced cards need the precisely correct face name to decide which face to render, so this PR additionally adds logging to make it clearer that the image file's name might be wrong.