Fix leveler regex failure cases#98
Open
Gavin-Bowers wants to merge 2 commits intoInvestigamer:mainfrom
Open
Conversation
Author
|
I fixed the regex pattern since I accidentally committed an unfinished version originally. I also added a fix for rendering cards with empty abilities, by making middle_text return a space instead of an empty string when the regex group is empty. I tested it this time to make sure the changes work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leveler regex pattern would fail to match or have incorrect groups on cards with empty level abilities (Lighthouse Chronologist) and cards with newlines in level abilities (Kargan Dragonlord). This fix replaces the pattern with one that handles these cases. In the case of an empty ability, the group now contains an empty string. The leveler template will still need to be changed for the placeholder text not to show up on cards with empty level abilities.