Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for readonly attribute on textarea #446

Closed
wants to merge 1 commit into from
Closed

Add support for readonly attribute on textarea #446

wants to merge 1 commit into from

Conversation

vanillajonathan
Copy link
Contributor

Closes #121

@vanillajonathan
Copy link
Contributor Author

Please merge!

@Ionaru
Copy link
Owner

Ionaru commented May 21, 2022

This could cause issues because we're changing the editor behaviour that people have been used to for years. New editor (#447) should definitely look at the readonly attribute, and probably others too.

@vanillajonathan
Copy link
Contributor Author

Yeah, it could lead to a different behavior if someone were using the readonly attribute today, but I find it unlikely that anyone would use it without desiring that functionality.

The disabled attribute is another attribute that could be considered for the new editor.

I'll close this PR then.

@vanillajonathan vanillajonathan deleted the patch-5 branch May 21, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How can I configure the editor to be display only?
2 participants
@vanillajonathan @Ionaru