Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the toggling behaviour in toggleLinks. #560

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pschijven
Copy link

This pull request fixes a small issue in the toggleLinks method.

Suppose I have selected the text uri and then press Cmd+K to create a link. Then the text [uri](https://) will be generated. If I press Cmd+K again, it currently reverts the text back to [uri instead of uri.

I have made a small correction to the regular expression in the toggleLinks method to fix this problem.

@erossini
Copy link

erossini commented Jul 1, 2024

I saw your code. Thank you, it fixed my issue. If you like, here the full code https://github.com/erossini/EasyMarkdownEditor

@pschijven
Copy link
Author

I saw your code. Thank you, it fixed my issue. If you like, here the full code https://github.com/erossini/EasyMarkdownEditor

I'm glad that I could be of help 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants