-
Notifications
You must be signed in to change notification settings - Fork 1
[EI-3347] Add support for binary download #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dbcaae5
to
2dc98b4
Compare
86e2692
to
ce7323b
Compare
|
||
Returns: | ||
The downloaded content as string or None, if the download fails. | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Let's discuss what's best to do with the
Data
class tomorrow.- Your change is obviously in line with what already exists so this might be fine as-is but let's see what we want to do.
CHANGELOG.md
should be updated with bits added for unreleased updates (yes - I know I've also forgotten to do so) - or we remove the changelog (since it's pointed to from PyPI) and use another method. I thought it'd be better to use this file than GH releases since that would make it GH-specific.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
All the feedback I have are minor things - consider at your discretion
ce7323b
to
d4c44d1
Compare
Issue
Currently we download all content as a string and store that string in the Data class. To prepare for additional file types, we should add support for binary downloads, without breaking existing usage.
Fix
Updated the data class
as_bytes
function, that returns the bytes contentas_string
function, which returns the string content of the file (as download did before)download
function, it just callsas_string
and is marked as depreciated, and to be removed in 0.2.0