feat: add T&C link to init script #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyantrim
force-pushed
the
ab-ei-3369-tandc
branch
from
e5bf2c2 to
93e822b
Compare
andyantrim
force-pushed
the
ab-ei-3369-tandc
branch
from
93e822b to
e645b19
Compare
conbon
reviewed
Sep 30, 2024
nyx_client/cli/init_env.py
Outdated
| @@ -35,6 +35,15 @@ def init_env(filename: str = ".env"): | |||
| click.echo("Exiting with no changes") | |||
| return | |||
|
|
|||
| # Check user is aware of T&Cs | |||
| tcs = input( | |||
| "The Nyx SDK allows the sharing of links through a Nyx Instance. " | |||
There was a problem hiding this comment.
Is this enough? or do we want to call out each point as in UI?
There was a problem hiding this comment.
Valid point, I think copying the UI makes sense, even if it's just for consistence
conbon
reviewed
Sep 30, 2024
| I confirm that I have the right to share this data. | ||
| I confirm that this data does not contain any Personally Identifiable Information | ||
| or otherwise sensitive information, and that it does not violate any laws. | ||
| I confirm I have read the Nyx Terms of Service and I am content to proceed. |
conbon
reviewed
Sep 30, 2024
nyx_client/cli/init_env.py
Outdated
| @@ -21,6 +21,19 @@ | |||
| from nyx_client.cli.common import SDK_CLI_DEFAULT_HEADERS | |||
| from nyx_client.identity_auth import IdentityAuth | |||
|
|
|||
| TERMS = """ | |||
| To use Nyx you must agree to our Terms of service when sharing content | |||
conbon
reviewed
Sep 30, 2024
nyx_client/cli/init_env.py
Outdated
| # Check user is aware of T&Cs | ||
| tcs = input(TERMS) | ||
| if tcs.lower() != "y": | ||
| click.echo("You must agree to the terms of service!") |
added 2 commits
September 30, 2024 12:04
conbon
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.