Prompt Improvement #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
conbon
commented
Sep 30, 2024
conbon
commented
- trim back some of the extraneous prompt to improve the agents SQL probing.
- remove dependency on the Utils prompts - include everything required in the system prompt
- fix some of the templating vars - printing the full prompt prior to this change showed incorrect templating
- remove the additional database tables - this appears to be a potential perf win, but the agent never seems to use the data
- fix and pin judge to a more capable model
vtermanis
reviewed
Sep 30, 2024
nyx_client/extensions/langchain.py
Outdated
| "input": "List all the characters in Anna Karenina", | ||
| "query": "SELECT DISTINCT characterNames FROM novels WHERE novelName = 'Anna Karenina'", | ||
| "ex_input": "What am I subscribed to?", | ||
| "ex_thought": "I need to find out what I am subscribed to. I will the tools available to me to query the " |
… to system prompt and add formatted examples.
conbon
force-pushed
the
cm-improve-prompt
branch
from
212277a to
34ff778
Compare
…r utils to system prompt and add formatted examples.
|
Can this go against the "feature" branch, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.