Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(client): Add more top-level imports #46

Merged
merged 2 commits into from
Dec 6, 2024
Merged

chore(client): Add more top-level imports #46

merged 2 commits into from
Dec 6, 2024

Conversation

vtermanis
Copy link
Contributor

@vtermanis vtermanis commented Dec 6, 2024 •
edited
Loading

Allow e.g.

from nyx_client import SparqlResultType

instead of

from nyx_client.client import SparqlResultType

@vtermanis
chore(client): Add more top-level imports
8778a96 
- SparqlResultType
- Connection
- Property
@vtermanis
chore(client): Fix relative doc references
2214e88 
- Use absolute ones to prevent sphinx warnings on generation
RPatterson1
RPatterson1 approved these changes Dec 6, 2024
View reviewed changes
Copy link

@RPatterson1 RPatterson1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, nice one - LGTM 👍

@vtermanis vtermanis merged commit bdb7d4e into main Dec 6, 2024
2 checks passed
@vtermanis vtermanis deleted the dev-vt-add-more-top-level-imports branch December 6, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RPatterson1 RPatterson1 RPatterson1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtermanis @RPatterson1