Miscellaneous improvements in deque#1942
Merged
BCSharp merged 3 commits intoIronLanguages:mainfrom Apr 14, 2025
Merged
Conversation
slozier
reviewed
Apr 10, 2025
| CompareUtil.Push(this); | ||
| try { | ||
| res = ((IStructuralEquatable)new PythonTuple(this)).GetHashCode(comparer); | ||
| res = ((IStructuralEquatable)new PythonTuple(GetObjectArray())).GetHashCode(comparer); |
Contributor
There was a problem hiding this comment.
I think we want PythonTuple.MakeTuple instead of the constructor? Not even sure when this code path gets called anyway?
Member
Author
There was a problem hiding this comment.
I think we want
PythonTuple.MakeTupleinstead of the constructor?
Yes!
Not even sure when this code path gets called anyway?
IDK either, it is not being tested by any of our tests. I have tested GetObjectArray in vitro. I guess it's there so that deque plays nicely with the rest of the .NET containers.
slozier
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a bit strange that the addition operator preserves the subclass type but multiplication and copy doesn't.