Skip to content

fix: add explicit TypeScript parser to prevent XML plugin conflicts #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zamiell merged 2 commits into from
Jul 19, 2025
Merged

fix: add explicit TypeScript parser to prevent XML plugin conflicts #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18d83d0
fix: ensure prettier recognizes .ts files due to a bug in prettier 3.…
sublimnl Jul 19, 2025
c91abf5
different fix
Zamiell Jul 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/isaacscript-cli/file-templates/static-mod/prettier.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ const config = {
plugins: [
"prettier-plugin-organize-imports", // Prettier does not format imports by default.
"prettier-plugin-packagejson", // Prettier does not format "package.json" by default.
"@prettier/plugin-xml", // Prettier does not format XML files by default.
// TODO: This plugin is bugged with the latest version of Prettier and tries to format
// TypeScript files as XML files.
/// "@prettier/plugin-xml", // Prettier does not format XML files by default.
],

overrides: [
Expand Down
4 changes: 3 additions & 1 deletion prettier.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ const config = {
plugins: [
"prettier-plugin-organize-imports", // Prettier does not format imports by default.
"prettier-plugin-packagejson", // Prettier does not format "package.json" by default.
"@prettier/plugin-xml", // Prettier does not format XML files by default.
// TODO: This plugin is bugged with the latest version of Prettier and tries to format
// TypeScript files as XML files.
/// "@prettier/plugin-xml", // Prettier does not format XML files by default.
],

overrides: [
Expand Down
Loading