Update starter site & matomo extra tools & fix permission Bugs #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required to fix build issue, that was being covered up by a previously successful cache.
A number of permission issues have gone unnoticed, I became aware of them when I did a fresh build without cache on a newly installed computer. When building Docker images, Docker copies files/folders with the same permissions as they have on the host machine. Git does not track the permissions of files except for the executable bit on files. So depending on who builds the images files/folders can get different permissions. This changes it such that the Makefile will ensure the appropriate permissions are set when building. This is required as we run services as different users other than root in the container. Those users must be able to access and execute certain files.
Merged
nigelgbanks
changed the title
aOelschlager
approved these changes
Sep 12, 2024
|
@aOelschlager thanks! That should be enough testing 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of permission issues have gone unnoticed,
I became aware of them when I did a fresh build
without cache on a newly installed computer.
When building Docker images, Docker copies
files/folders with the same permissions as they
have on the host machine. Git does not track the
permissions of files except for the executable bit
on files. So depending on who builds the images
files/folders can get different permissions.
This changes it such that the Makefile will ensure
the appropriate permissions are set when building.
This is required as we run services as different
users other than root in the container. Those
users must be able to access and execute certain
files.